fix: Check languageName exists before printing in keyboard details#503
Merged
darcywong00 merged 1 commit intomasterfrom Nov 26, 2024
Merged
fix: Check languageName exists before printing in keyboard details#503darcywong00 merged 1 commit intomasterfrom
darcywong00 merged 1 commit intomasterfrom
Conversation
srl295
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing #502 locally and saw this PHP error on
http://keyman.com.localhost/keyboards/sil_ipa
This adds a check for
languageNamebefore printing them in keyboard details.