Make all paths relative#95
Merged
Merged
Conversation
3 tasks
jmcarcell
reviewed
May 21, 2026
jmcarcell
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
First patch on the journey to fix #88
Running the reconstruction with Pandora from a different directory still fails because of
CLDConfig/CLDConfig/PandoraSettingsCLD/PandoraSettingsDefault.xml
Line 100 in 691ef7e
Handling this without creating a new file every time would need an extension of Pandora and its API to offer a copy of
Pandora::ReadSettingsthat takes the XML as a string directly. Then we could dynamically rewrite the path from our side. This will be left for a future PR.