-
Notifications
You must be signed in to change notification settings - Fork 511
Fix dump memory #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix dump memory #2771
Conversation
Summary of ChangesHello @nalves599, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the reliability and robustness of the memory dumping functionality within the Linux analyzer. It refines how memory regions are identified and processed by improving the parsing of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix memory dumping by updating the regex for parsing /proc/<pid>/maps and improving error logging. It also includes a fix for a potential KeyError in lib/cuckoo/common/objects.py.
I've found a critical issue in analyzer/linux/analyzer.py where the application could crash if a line from the maps file doesn't match the regular expression. I've provided a suggestion to fix this. The other changes look good.
This is a temporary fix because when processing the Linux memory dumps it fails with an undefined value. Current it is incorrectly parsing the dump, but this is useful to visualize the dumps.
57d76e2 to
5a7a1f2
Compare
|
@dsecuma get a look on this please when you will can |
No description provided.