Fix 'machines' vars on Azure

[Grand-Duc]

It seems that commit ba590a7 introducing modification to database.py broke az.py filter_kwargs dict :

[lib.cuckoo.core.scheduler] ERROR: Failed to find next serviceable task
Traceback (most recent call last):
File "/opt/CAPEv2/lib/cuckoo/core/scheduler.py", line 119, in do_main_loop_work
task, machine = self.find_next_serviceable_task(max_machines_reached)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/CAPEv2/lib/cuckoo/core/scheduler.py", line 154, in find_next_serviceable_task
task, machine = self.find_pending_task_to_service()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/CAPEv2/lib/cuckoo/core/scheduler.py", line 196, in find_pending_task_to_service
machine = self.machinery_manager.find_machine_to_service_task(task_candidate)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/CAPEv2/lib/cuckoo/core/machinery_manager.py", line 209, in find_machine_to_service_task
machine = self.machinery.find_machine_to_service_task(task)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/CAPEv2/modules/machinery/az.py", line 627, in find_machine_to_service_task
filtered_machines = self.db.filter_machines_to_task(include_reserved=False, **filter_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: _Database.filter_machines_to_task() got an unexpected keyword argument 'machines'

As 'machines' was replaced with 'statement' in filter_machines_to_task()

I did not review and understood all changes which resulted from this commit, but it corrected the issue on my tests.

[gemini-code-assist]

Summary of Changes

Hello @Grand-Duc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and fixes a TypeError that was introduced in the Azure machinery module (az.py) following a recent commit to database.py. The error specifically arose because the filter_kwargs dictionary was passing an incorrect keyword argument (machines instead of statement) to the filter_machines_to_task function. The change ensures that the machine filtering logic functions correctly for Azure environments, restoring proper operation.

Highlights

• Bug Fix: Resolves a TypeError in modules/machinery/az.py that occurred when calling _Database.filter_machines_to_task() due to an unexpected keyword argument.
• Parameter Alignment: Updates the filter_kwargs dictionary in az.py to use statement instead of machines as the key for passing the machine query, aligning with recent changes in database.py.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a critical bug in the Azure machinery module, where a TypeError occurred due to a keyword argument name change in a recent commit. The fix replaces machines with statement in the filter_kwargs dictionary, aligning with the updated filter_machines_to_task function signature. My review confirms this change is correct and necessary. I've also added a comment regarding a related code style inconsistency with SQLAlchemy versions for future maintainability improvements.

[doomedraven]

thank you

[doomedraven]

could you please check this update to use sqlalchemy 2? #2756