Conversation
…nService api definition
|
This is a really good first start. This has been requested in the past, just haven't had cycles to go an implement it, so thanks for giving it a shot. Couple of comments:
-kevin |
|
Hey, thanks for the feedback.
|
|
I imagine it will probably turn into a drop down with a few options. I think I'm going to have to play with it a bit and check-in the change to allow for it, then we can build this on top of it. |
|
Hello! PS: If you need help with translation to Russian, I can help |
|
Hi! This PR would need to be rebased to be able to be reviewed. After looking into it, I think it would be a better approach to use the i18n features of Angular directly: https://angular.io/guide/i18n This would certainly be easier for new translations. |
|
I'm going to look into it, I don't think it should be that hard to use the Angular i18n and this pull-request as a basis for translation! |
This adds a basic i18n/l10n support. The main goal was to make achi URLs localized, i.e. a user selects the XX language and all WowHead URLs turn from
http://wowhead.com/...intohttp://XX.wowhead.com/...which also makes the achi popups localized.But that would be somewhat weird to let user choose language and only update URLs, thus the UI translation was made possible as well (
header.htmlas an example).