Skip to content

ci: add Semgrep SAST scanning on pull requests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulziibay-kernel merged 1 commit into from
Apr 10, 2026
+25 −0
Merged

ci: add Semgrep SAST scanning on pull requests #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/semgrep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Semgrep

on:
pull_request:
branches: [main]

permissions:
contents: read
pull-requests: write

jobs:
scan:
uses: kernel/security-workflows/.github/workflows/semgrep.yml@main
with:
extra-configs: '--config p/javascript --config p/typescript'
codebase-description: 'Hosted MCP server handling authenticated tool execution and browser session data'
secrets: inherit
8 changes: 8 additions & 0 deletions .semgrepignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
node_modules/
dist/
.next/
out/
bun.lock
package-lock.json
**/*.test.ts
**/*.spec.ts
Copy link
Copy Markdown

@cursor cursor bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrepignore misses .tsx test file patterns

Low Severity

The .semgrepignore excludes **/*.test.ts and **/*.spec.ts but not **/*.test.tsx and **/*.spec.tsx. Since .semgrepignore uses .gitignore-style glob matching, a *.ts pattern does not match .tsx files. This is a Next.js/React project with .tsx files throughout (page.tsx, layout.tsx, component files), so React component tests will naturally use .test.tsx/.spec.tsx extensions and won't be excluded from scanning, contradicting the stated intent.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 72a946a. Configure here.