Skip to content

ci: add lint and build checks on PRs #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ulziibay-kernel wants to merge 4 commits into
base: main
Choose a base branch
from
+19 −0
Open

ci: add lint and build checks on PRs #93

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a197e7
ci: add lint and build checks on PRs
ulziibay-kernel Apr 8, 2026
de12f85
fix(ci): use format:check and build instead of broken next lint
ulziibay-kernel Apr 8, 2026
e287ef4
fix(ci): use build only — format:check fails on pre-existing issues
ulziibay-kernel Apr 8, 2026
290a457
fix(ci): use tsc --noEmit — next build requires runtime env vars
ulziibay-kernel Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: CI

on:
pull_request:
branches: [main]
merge_group:

jobs:
ci:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: oven-sh/setup-bun@v2

- run: bun install --frozen-lockfile

- name: Format check
run: bun run format:check
Copy link
Copy Markdown

@cursor cursor Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI runs format check instead of lint as described

Medium Severity

The PR description states this workflow "runs bun run lint and bun run build" for SOC 2 CHG-1 compliance, but the workflow actually runs bun run format:check instead of bun run lint. These are fundamentally different checks — lint runs ESLint to catch code bugs and anti-patterns, while format:check only runs Prettier to verify whitespace and formatting. The SOC 2 compliance claim of "enforces automated testing before merge" is weakened since no actual linting occurs. Per AGENTS.md, next lint is broken on Next.js 16, so either a working ESLint configuration needs to be set up, or the compliance documentation needs to accurately reflect that only formatting is checked.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit de12f85. Configure here.


- name: Build
run: bun run build
Loading