Skip to content

[kernel-1116] remaining cdp handlers#215

Merged
archandatta merged 3 commits intoarchand/kernel-1116/cdp-monitor-corefrom
archand/kernel-1116/cdp-handlers
Apr 13, 2026
Merged

[kernel-1116] remaining cdp handlers#215
archandatta merged 3 commits intoarchand/kernel-1116/cdp-monitor-corefrom
archand/kernel-1116/cdp-handlers

Conversation

@archandatta
Copy link
Copy Markdown
Contributor

@archandatta archandatta commented Apr 13, 2026

Final layer of the CDP monitor split. Replaces the no-op dispatchEvent stub with the full handler implementation and completes the test suite. Merges cleanly on top of #214


Note

Medium Risk
Adds full CDP event dispatch/handling and emits richer network/page interaction events (including headers and optional response bodies), which can affect event volume and expose sensitive data to downstream consumers.

Overview
Completes the CDP monitor split by replacing the no-op dispatchEvent stub with a full handler implementation that publishes console, page/navigation, target, interaction binding, timeline layout-shift, and detailed network request/response events (including optional truncated response bodies for textual resources).

Improves lifecycle/computed-state correctness by handling redirects without inflating pending counters, ignoring subframe lifecycle events for main-frame settling logic, and standardizing published event timestamps to microseconds (including screenshots and monitor lifecycle events). Adds an extensive test suite covering these handlers, rate-limiting of binding events, auto-attach/attach-existing-targets flows, and the redirect/subframe edge cases; updates API wiring to pass a slog logger into cdpmonitor.New.

Reviewed by Cursor Bugbot for commit b5b3e89. Bugbot is set up for automated code reviews on this repo. Configure here.

@archandatta archandatta changed the base branch from main to archand/kernel-1116/cdp-monitor-core April 13, 2026 14:39
@archandatta archandatta marked this pull request as ready for review April 13, 2026 15:04
@archandatta archandatta force-pushed the archand/kernel-1116/cdp-monitor-core branch from 70361be to bfb6cd7 Compare April 13, 2026 15:15
@archandatta archandatta force-pushed the archand/kernel-1116/cdp-handlers branch from 01cc564 to a64605e Compare April 13, 2026 15:17
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a64605e. Configure here.

@archandatta archandatta requested review from Sayan-, hiroTamada and rgarcia and removed request for hiroTamada and rgarcia April 13, 2026 15:28
@archandatta archandatta merged commit 9092789 into archand/kernel-1116/cdp-monitor-core Apr 13, 2026
3 checks passed
@archandatta archandatta deleted the archand/kernel-1116/cdp-handlers branch April 13, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant