[kernel-1116] remaining cdp handlers#215
Merged
archandatta merged 3 commits intoarchand/kernel-1116/cdp-monitor-corefrom Apr 13, 2026
Merged
[kernel-1116] remaining cdp handlers#215archandatta merged 3 commits intoarchand/kernel-1116/cdp-monitor-corefrom
archandatta merged 3 commits intoarchand/kernel-1116/cdp-monitor-corefrom
Conversation
70361be to
bfb6cd7
Compare
01cc564 to
a64605e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a64605e. Configure here.
9092789
into
archand/kernel-1116/cdp-monitor-core
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Final layer of the CDP monitor split. Replaces the no-op dispatchEvent stub with the full handler implementation and completes the test suite. Merges cleanly on top of #214
Note
Medium Risk
Adds full CDP event dispatch/handling and emits richer network/page interaction events (including headers and optional response bodies), which can affect event volume and expose sensitive data to downstream consumers.
Overview
Completes the CDP monitor split by replacing the no-op
dispatchEventstub with a full handler implementation that publishes console, page/navigation, target, interaction binding, timeline layout-shift, and detailed network request/response events (including optional truncated response bodies for textual resources).Improves lifecycle/computed-state correctness by handling redirects without inflating pending counters, ignoring subframe lifecycle events for main-frame settling logic, and standardizing published event timestamps to microseconds (including screenshots and monitor lifecycle events). Adds an extensive test suite covering these handlers, rate-limiting of binding events, auto-attach/attach-existing-targets flows, and the redirect/subframe edge cases; updates API wiring to pass a
sloglogger intocdpmonitor.New.Reviewed by Cursor Bugbot for commit b5b3e89. Bugbot is set up for automated code reviews on this repo. Configure here.