ci: add Semgrep SAST scanning on pull requests #211
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: Semgrep | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| scan: | ||
| uses: kernel/security-workflows/.github/workflows/semgrep.yml@main | ||
| with: | ||
| extra-configs: '--config p/golang --config p/javascript' | ||
| codebase-description: 'Base browser images with Go server and JS client' | ||
| secrets: inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| node_modules/ | ||
| vendor/ | ||
| dist/ | ||
| .next/ | ||
| *_test.go | ||
| go.sum | ||
| package-lock.json | ||
| server/lib/oapi/oapi.go | ||
|
There was a problem hiding this comment. Generated file not excluded from Semgrep scanningLow Severity The   Reviewed by Cursor Bugbot for commit 42c18c8. Configure here. |
||
| images/chromium-headful/client/ | ||
| shared/cdp-test/ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
bun.lockin.semgrepignorelock file listLow Severity
The
.semgrepignoreincludesgo.sumandpackage-lock.jsonas lock files to ignore, but the repository actually usesbun.lock(present at the repo root alongsidepackage.jsonwith@types/bunas a dev dependency). This lock file is not listed in the ignore file, inconsistent with the stated intent to exclude lock files from scanning.Reviewed by Cursor Bugbot for commit a2daadf. Configure here.