Skip to content

Raise recording framerate limit from 20 to 60 fps #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
guergabo wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

Raise recording framerate limit from 20 to 60 fps #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/cmd/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ func validate(config *Config) error {
if config.DisplayNum < 0 {
return fmt.Errorf("DISPLAY_NUM must be greater than 0")
}
if config.FrameRate < 0 || config.FrameRate > 20 {
return fmt.Errorf("FRAME_RATE must be greater than 0 and less than or equal to 20")
if config.FrameRate < 0 || config.FrameRate > 60 {
return fmt.Errorf("FRAME_RATE must be greater than 0 and less than or equal to 60")
}
if config.MaxSizeInMB < 0 || config.MaxSizeInMB > 1000 {
return fmt.Errorf("MAX_SIZE_MB must be greater than 0 and less than or equal to 1000")
Expand Down
2 changes: 1 addition & 1 deletion server/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ components:
type: integer
description: Recording framerate in fps (overrides server default)
minimum: 1
maximum: 20
maximum: 60
maxDurationInSeconds:
type: integer
description: Maximum recording duration in seconds (overrides server default)
Expand Down
Loading