Merged
Conversation
hiroTamada
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CIinto the sudo-backed Linuxgo testinvocations inmake testRoot cause
Linux CI runs tests through
make test, which usessudo env ... go test ....That command forwarded
PATH,DOCKER_CONFIG, and the prewarm vars, but notCI.As a result, integration-test helpers like
integrationTestTimeout(...)behaved as if they were running locally, so sub-45s waits stayed at 20s instead of widening on CI.This surfaced in the latest
mainmerge as a flaky failure inTestStandbyAndRestoreduring the initial create-to-running wait.Verification
deft-kernel-devthat the child sudo test process now receivesCI=truemake test TEST=TestStandbyAndRestore TEST_TIMEOUT=90mremotely withCI=trueNote
Low Risk
Low risk Makefile-only change that only affects how test processes inherit environment variables under
sudo. Main risk is unintended behavior differences in local Linux runs ifCIis set in the caller environment.Overview
Fixes Linux test runs invoked via
sudo env ... go testto preserve theCIenvironment variable, aligning integration-test behavior (e.g., CI-specific timeouts) with actual CI execution.Applies the same
CIforwarding to thetest-guestmemory-linuxmanual integration test target for consistency.Reviewed by Cursor Bugbot for commit 3f3331b. Bugbot is set up for automated code reviews on this repo. Configure here.