Skip to content

fix: Linux CI test env propagation#190

Merged
sjmiller609 merged 1 commit intomainfrom
codex/fix-linux-ci-timeout-env
Apr 8, 2026
Merged

fix: Linux CI test env propagation#190
sjmiller609 merged 1 commit intomainfrom
codex/fix-linux-ci-timeout-env

Conversation

@sjmiller609
Copy link
Copy Markdown
Collaborator

@sjmiller609 sjmiller609 commented Apr 8, 2026

Summary

  • forward CI into the sudo-backed Linux go test invocations in make test
  • do the same for the manual Linux guest-memory test entrypoint for consistency
  • restore the repo's intended CI timeout behavior for Linux integration tests

Root cause

Linux CI runs tests through make test, which uses sudo env ... go test ....
That command forwarded PATH, DOCKER_CONFIG, and the prewarm vars, but not CI.
As a result, integration-test helpers like integrationTestTimeout(...) behaved as if they were running locally, so sub-45s waits stayed at 20s instead of widening on CI.

This surfaced in the latest main merge as a flaky failure in TestStandbyAndRestore during the initial create-to-running wait.

Verification

  • verified on deft-kernel-dev that the child sudo test process now receives CI=true
  • ran make test TEST=TestStandbyAndRestore TEST_TIMEOUT=90m remotely with CI=true
  • also ran targeted remote repro loops before the fix to confirm the failure was contention-sensitive rather than a deterministic restore bug

Note

Low Risk
Low risk Makefile-only change that only affects how test processes inherit environment variables under sudo. Main risk is unintended behavior differences in local Linux runs if CI is set in the caller environment.

Overview
Fixes Linux test runs invoked via sudo env ... go test to preserve the CI environment variable, aligning integration-test behavior (e.g., CI-specific timeouts) with actual CI execution.

Applies the same CI forwarding to the test-guestmemory-linux manual integration test target for consistency.

Reviewed by Cursor Bugbot for commit 3f3331b. Bugbot is set up for automated code reviews on this repo. Configure here.

@sjmiller609 sjmiller609 changed the title Fix Linux CI test env propagation fix: Linux CI test env propagation Apr 8, 2026
@sjmiller609 sjmiller609 marked this pull request as ready for review April 8, 2026 13:56
@sjmiller609 sjmiller609 requested a review from hiroTamada April 8, 2026 14:14
@sjmiller609 sjmiller609 merged commit 4dc8607 into main Apr 8, 2026
8 checks passed
@sjmiller609 sjmiller609 deleted the codex/fix-linux-ci-timeout-env branch April 8, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants