Skip to content

Adding the animal-java app#6

Open
Aditya-eddy wants to merge 2 commits intokeploy:mainfrom
Aditya-eddy:main
Open

Adding the animal-java app#6
Aditya-eddy wants to merge 2 commits intokeploy:mainfrom
Aditya-eddy:main

Conversation

@Aditya-eddy
Copy link
Copy Markdown
Member

Pull Request Template

Description

Adding the Java-demo application.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
@charankamarapu charankamarapu self-requested a review August 19, 2024 10:47
@charankamarapu
Copy link
Copy Markdown
Collaborator

Firstly add the app in the docker file like we did for other apps.

@charankamarapu
Copy link
Copy Markdown
Collaborator

Have you ran the app with Kelpoy and saw if test cases are being record and test mode is working fine..?

Copy link
Copy Markdown
Collaborator

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reply to the above comments and resolve them

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
@Aditya-eddy
Copy link
Copy Markdown
Member Author

hey @charankamarapu i have checked it for recording and testing. Can you please check from your side if something is in-complete also please check the DockerFIle i have updated it. Thanks!!
I'll attach the screenshot:
Screenshot from 2024-08-19 17-10-13

@keploy
Copy link
Copy Markdown

keploy bot commented Apr 15, 2025

To generate Unit Tests for this PR, please click here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants