chore: promote code review fixes and di improvements to main#14
Merged
Conversation
… quality - move AllExceptionsFilter and TransformInterceptor from main.ts new instantiation to AppModule via APP_FILTER and APP_INTERCEPTOR tokens - move AuthGuard to AppModule via APP_GUARD token - change ArcjetOptionalGuard registration from useFactory to useExisting so it can be overridden in tests - create src/common/decorators/current-user.decorator.ts as a fully typed param decorator replacing direct req.user access across controllers - update task, comment, and project controllers to use CurrentUser decorator instead of Req with manual user extraction and null guards - change UpdateCommentDto from hand-written fields to extends PartialType of CreateCommentDto - change task service where clause type from Record string unknown to Prisma.TaskWhereInput - add transform true to ValidationPipe in main.ts - replace AllowAnonymous with Public decorator in app.controller.ts - simplify task, comment, and project controller specs by passing user objects directly instead of mock Request with as unknown cast - add as const to mockUser.role in user.service.spec.ts
… quality Moves AllExceptionsFilter, TransformInterceptor, and AuthGuard from main.ts new instantiation to AppModule via APP_FILTER, APP_INTERCEPTOR, and APP_GUARD tokens, switches ArcjetOptionalGuard from useFactory to useExisting, creates a CurrentUser param decorator replacing Req with null guard boilerplate across three controllers, adds PartialType inheritance to UpdateCommentDto, types the task service where clause as Prisma.TaskWhereInput, adds transform true to the global ValidationPipe, replaces AllowAnonymous with Public in app.controller, simplifies three controller specs by removing mock Request casts, and adds as const to the role literal in user.service.spec.
Dependency ReviewThe following issues were found:
License Issues.opencode/package-lock.json
OpenSSF ScorecardScorecard details
Scanned Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes the DI improvements, CurrentUser decorator, type fixes, and test cleanup from develop into main.
What's Changed
Why
These correctness fixes should be reflected on the stable branch before any further feature work is added on top of the module system.