Open
Conversation
-V was remapped from --version to --version-sort. The old test passed -V with no files, causing stdin read and a hang. The --version test already covers version output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"sort -V shows version"unit test that hangs because-Vwas remapped from--versionto--version-sort"sort --version shows version"test already covers version output-Vnow meaning version-sort, passing it with no files causes stdin read, hanging the test suiteTest plan
timeout 300 zig build test --summary allcompletes with no sort hangs (1915/1939 pass; the one failure is a pre-existing mv test)just it-util sortpasses all 45 integration tests