Open
Conversation
nl: Fix test expectations to match GNU behavior. Footer counter resets on section transition (POSIX/GNU). Blank line join test uses printf for exact whitespace matching. head: Change -n negative value test from -5 (now valid as negative suffix) to 0x5 (truly invalid). timeout: Preprocess args to insert -- before COMMAND so child flags like bash -c are not parsed by timeout. Return KILL exit code (137) when --kill-after fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printffor exact whitespace matching (7-space indent on unnumbered blanks, tab after numbered blanks).-n negative valuetest from-5(now valid as negative suffix meaning "all but last 5") to0x5(truly invalid value), matching the unit test fix in 5f45c28.preprocessArgsto insert--before COMMAND positional so child flags (e.g.,bash -c) are not parsed by timeout's argparse. Return KILL exit code (137) when--kill-afterfires instead of generic 124.Test plan
just it-util nl-- 55/55 passjust it-util head-- 83/83 passjust it-util timeout-- 26/26 passzig build test-- all unit tests pass