Add failing tests for env and free IMPORTANT audit findings#13
Open
Add failing tests for env and free IMPORTANT audit findings#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env findings tested
given together. Currently passes through to exec instead of
erroring with exit 125.
token, subsequent flag-like tokens should start the command.
Currently
-uafterFOO=baris still parsed as a flag.search path for the utility, not the child's PATH variable.
Currently
env -i -P /path FOO=barshows PATH in output.free findings tested
buffers+cached into buff_cache, losing the individual buffers
value. Wide mode hardcodes 0 for the buffers column.
"free: -c requires -s option". We silently display once.
sifieldname[0]='s' as its short flag, so
-ssets si=true insteadof --seconds. Makes
-s 1 -c 1fail with "extra operand".Test plan
zig build test --summary all)