feat: add Helm chart publishing workflow to release process#806
feat: add Helm chart publishing workflow to release process#806stearz wants to merge 4 commits intokelos-dev:mainfrom
Conversation
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release.yaml">
<violation number="1" location=".github/workflows/release.yaml:95">
P2: Release workflow uses unpinned Helm version (`latest`), making chart publishing non-reproducible and susceptible to upstream changes.</violation>
<violation number="2" location=".github/workflows/release.yaml:141">
P2: `git commit` runs unconditionally; if there are no changes (e.g., rerun tag), it exits non‑zero and fails the workflow. Add a no-op guard to make the step idempotent.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
.github/workflows/release.yaml
Outdated
| - name: Install Helm | ||
| uses: azure/setup-helm@v4 | ||
| with: | ||
| version: latest |
There was a problem hiding this comment.
I think pining to v3 or v4 here is useful. I know I am still on v3 because of breaking changes in v4 but having it be latest I don't think is great? Renovate or dependabot can configure this and bump it without issue
Changes publish-helm-chart workflow: - Use OCI registry (ghcr.io) instead of separate helm-charts repository Users can now install with: helm install kelos oci://ghcr.io/kelos-dev/kelos --version v1.0.0
Please check cfe977f |
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release.yaml">
<violation number="1" location=".github/workflows/release.yaml:88">
P2: `publish-helm-chart` removes `contents: read` while still running `actions/checkout@v4`, which can fail due to insufficient permissions and block chart publishing.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
What type of PR is this?
feature
What this PR does / why we need it:
Github action that releases the helm chart to separate heln
repo
Which issue(s) this PR is related to:
Fixes #805
Fixes #781
Special notes for your reviewer:
The target repository still needs to be created manually:
Does this PR introduce a user-facing change?
users can now install kelos using the official helm chart repo