Support the status of EQC availability changing at runtime#30
Open
Vagabond wants to merge 2 commits intokellymclaughlin:masterfrom
Open
Support the status of EQC availability changing at runtime#30Vagabond wants to merge 2 commits intokellymclaughlin:masterfrom
Vagabond wants to merge 2 commits intokellymclaughlin:masterfrom
Conversation
Since EQC is a third party library that is usually installed into the system path, often it's availability changes as the erlang version changes or EQC is installed. The plugin adapts to these changes by recompiling itself to match the current EQC status for the current Erlang install and thus avoids having to manually clean up the plugin to force it to recompile.
Owner
|
Thanks, Andrew! Give me a couple of days to look over this and I'll get it merged and make a new release. |
Author
|
#28 is actually quite similar but a lot less complicated (but the coverdata fix still seems useful). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One problem with the current plugin is that if it's compiled before EQC is available, it won't work thereafter until you manually delete it and force it to be recompiled. This can happen quite a bit if you have several Erlang installs and switch between them, but don't have EQC installed in every one.
This PR allows the plugin to recompile itself if the status of EQC changes, when EQC is not available it tells you to install it and when EQC becomes available the plugin recompiles itself to reflect that.
Additionally this PR fixes an issue with coverdata from EQC tests being written.