feat: use Self on impl return of itself#409
Merged
keepsimple1 merged 1 commit intokeepsimple1:mainfrom Dec 4, 2025
Merged
Conversation
keepsimple1
approved these changes
Dec 4, 2025
Owner
keepsimple1
left a comment
keepsimple1
left a comment
There was a problem hiding this comment.
Thanks, LGTM! For the clippy::use_self lint, Iet's hold it for now, until it becomes part of the default clippy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every implementation that returns self is marked with
Self, not the explicit way. This is the sole location that isn't like the others.This is a trivial PR of maintaining the code style, feel free to close if not appropriate.
This change is a part of the clippy::use_self lint, there are other 35 instances where the explicit type could be replaced by
Self(although not in the return position), some places maintain this and others do not, if this is a wanted change I could replace them and also add the lint to the CI!