feat(e2e): add temporal-deployment-worker image#249
Draft
veeral-patel wants to merge 1 commit into
Draft
Conversation
Adds a minimal Temporal worker that enables Worker Deployment
Versioning via the Go SDK's `DeploymentOptions{UseVersioning: true}`
option. Needed by the KEDA Temporal scaler e2e test for the new
deployment-version code path (kedacore/keda#7672).
The existing `temporaliotest/omes` image supports build-id versioning
but not deployment versioning, so KEDA cannot reuse it.
The build script will publish this as
ghcr.io/kedacore/tests-temporal-deployment-worker:latest based on
the directory name.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Veeral Patel <veeral.patel@temporal.io>
Author
|
Created this PR but not ready for review yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a minimal Temporal worker binary to `e2e/images/temporal-deployment-worker/`. The build pipeline will publish it as `ghcr.io/kedacore/tests-temporal-deployment-worker:latest`.
Why
The KEDA Temporal scaler's e2e test has a new subtest (in kedacore/keda#7672) for scaling by Worker Deployment Version backlog. That path exercises the server's `DescribeWorkerDeploymentVersion` API, which only returns populated stats when a worker has registered against a given deployment version using the Go SDK's `worker.DeploymentOptions{UseVersioning: true, Version: ...}` option.
The existing `temporaliotest/omes` image that KEDA's other Temporal e2e subtests use supports only the legacy build-id versioning (`--build-id`); it doesn't expose a flag to enable deployment versioning. So the KEDA PR needs its own minimal worker image — this one.
What it is
Companion PR
kedacore/keda#7672 — which will switch its e2e test template from the locally-built `temporal-deployment-worker:latest` to `ghcr.io/kedacore/tests-temporal-deployment-worker:latest` once this image is published.