docs: require tests before adding or modifying features#31
Open
kebot wants to merge 3 commits into
Open
Conversation
Adds a Testing section to CLAUDE.md establishing TDD as the workflow: write the test file first, mock Tauri APIs following the ScreenContext pattern, and co-locate test files with their source. https://claude.ai/code/session_0177LvgF71Ss7kEyMB54CLjf
Runs on every pull_request and push to main. Uses ubuntu-latest (no macOS needed for JS checks) to keep it fast and cheap. https://claude.ai/code/session_0177LvgF71Ss7kEyMB54CLjf
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CLAUDE.md documentation by adding a new 'Testing' section that outlines TDD practices, test execution commands, and mocking strategies for Tauri APIs. A review comment identifies that the documentation references a non-existent file as a mocking example, which needs to be addressed to ensure the instructions are actionable.
@vitejs/plugin-react@6 requires vite@^8; the previous ^7.0.4 constraint caused CI to install incompatible versions, breaking vitest startup with ERR_PACKAGE_PATH_NOT_EXPORTED on vite/internal. https://claude.ai/code/session_0177LvgF71Ss7kEyMB54CLjf
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Testing section to CLAUDE.md establishing TDD as the workflow:
write the test file first, mock Tauri APIs following the ScreenContext
pattern, and co-locate test files with their source.
https://claude.ai/code/session_0177LvgF71Ss7kEyMB54CLjf