Conversation
ondrajodas
force-pushed
the
ondra-AJDA-800
branch
from
d0c8685 to
aa3f27c
Compare
| Assert::assertEquals(1, count($usersManifests)); | ||
| } | ||
|
|
||
| public function testAppUserException(): void |
There was a problem hiding this comment.
testy pro odstraněný Universal Analytics, pomalu vypínají služby tak musíme odmazávat testy...chtělo by to teda pročistit i kod
There was a problem hiding this comment.
OK, tenhle test chapu, ten assert byl stejne divnej :D
MiroCillik
left a comment
MiroCillik
left a comment
There was a problem hiding this comment.
Jen nechapu proc se odmazava i test "testAppAuthException", jinak LGTM
| Assert::assertEquals(1, count($usersManifests)); | ||
| } | ||
|
|
||
| public function testAppUserException(): void |
There was a problem hiding this comment.
OK, tenhle test chapu, ten assert byl stejne divnej :D
| public function testAppAuthException(): void | ||
| { | ||
| $this->config = $this->getConfig(); | ||
| $this->config['parameters']['retriesCount'] = 0; | ||
| $this->config['authorization']['oauth_api']['credentials'] = [ | ||
| 'appKey' => getenv('CLIENT_ID'), | ||
| '#appSecret' => getenv('CLIENT_SECRET'), | ||
| '#data' => json_encode([ | ||
| 'access_token' => 'cowshit', | ||
| 'refresh_token' => 'bullcrap', | ||
| ]), | ||
| ]; | ||
| $errorOutput = $this->runProcess()->getErrorOutput(); | ||
| Assert::assertStringContainsString('Expired or wrong credentials, please reauthorize.', $errorOutput); | ||
| } |
There was a problem hiding this comment.
Ale co je spatne na tomhle testu?
There was a problem hiding this comment.
volal se tam ještě starý endpoint na UA který už je dávno deprecated - https://github.com/keboola/google-analytics-extractor/actions/runs/16517331264/job/46710920611#step:4:663
3 participants
https://keboola.atlassian.net/browse/AJDA-800