Recent fixes to get example to work again #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to int conversion'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of issues prevent anyone from using the lib in it's current state.
Since the last fix-up, examples were broken.
Examples was updated so it will at least run, many tests still fail.
You have an undocumented eventghost server running not apart of the repo. After the capture, __set_name callback is run, but without the server, we timeout, and as a result, the example callback for durations would never complete, and every button would fail.
Also another subtle error, hexdecimal ---> hexadecimal.
The other tests that fail, I will take a look at. It's been a while since your last update, maybe all of these are solved locally.