bugfix: in Python 3.x, msvcrt.getch() return a byte string not a character#4
Open
li-rupert wants to merge 13 commits intokcsaff:masterfrom
Open
bugfix: in Python 3.x, msvcrt.getch() return a byte string not a character#4li-rupert wants to merge 13 commits intokcsaff:masterfrom
li-rupert wants to merge 13 commits intokcsaff:masterfrom
Conversation
Open
…ows for both Python 2.7 and 3.6)
|
@kcsaff, any possibility on getting this PR merged in? It fixes at least two issues I've run into when using Python 3:
|
EnGamma
reviewed
May 14, 2021
EnGamma
left a comment
EnGamma
left a comment
There was a problem hiding this comment.
I endorse merging these changes into kcsaff:master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 79bfdd6 should fix issue #1
commit 2c2bf7e should fix issue #2 (comes from mtikekar)