Skip to content

proxy:implement readyz and livez handlers#3935

Open
nuromirg wants to merge 1 commit intokcp-dev:mainfrom
nuromirg:implement-health-readiness-checks
Open

proxy:implement readyz and livez handlers#3935
nuromirg wants to merge 1 commit intokcp-dev:mainfrom
nuromirg:implement-health-readiness-checks

Conversation

@nuromirg
Copy link

Summary

Replace the stub OK responses on /readyz and /livez with health checks using the recommended k8s.io/apiserver/pkg/server/healthz package from issue description.

In short,

  • /readyz uses NewInformerSyncHealthz and reports ready only once the shared informer factory caches have synced
  • /livez now uses PingHealthz for liveness ping (didn't find any meaningful broken-but-alive state, I assume that simple ping-pong would be fine)

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #3916

Release Notes

NONE

Signed-off-by: Nikita Rudakov <nikita.rudakov@sap.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 22, 2026
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mjudeikis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2026
@kcp-ci-bot
Copy link
Contributor

Hi @nuromirg. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ntnn
Copy link
Member

ntnn commented Mar 25, 2026

Thanks @nuromirg for the contribution!
/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2026
@ntnn ntnn added this to tbd Mar 25, 2026
@github-project-automation github-project-automation bot moved this to Backlog in tbd Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Implement readyz and livez handlers for the proxy server

3 participants