proxy:implement readyz and livez handlers#3935
Conversation
Signed-off-by: Nikita Rudakov <nikita.rudakov@sap.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @nuromirg. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @nuromirg for the contribution! |
Summary
Replace the stub
OKresponses on/readyzand/livezwith health checks using the recommendedk8s.io/apiserver/pkg/server/healthzpackage from issue description.In short,
/readyzusesNewInformerSyncHealthzand reports ready only once the shared informer factory caches have synced/liveznow usesPingHealthzfor liveness ping (didn't find any meaningful broken-but-alive state, I assume that simple ping-pong would be fine)What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #3916
Release Notes