Prevent spurious failures due to APIBindings not being ready

[ntnn]

Summary

So I'm not sure about this. Not every workspace requires the kcp APIs to be ready for their test case. On the other hand it wouldn't hurt to wait the few milliseconds more.

Alternatively we'd have to add similar waits to all tests that do require the kcp APIs over time, which is a lot of tests.

In CI errors related to kcp resources sometimes come up, e.g.:

workspace_test.go:556:
    	Error Trace:	/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/authentication/workspace_test.go:556
    	Error:      	"the server could not find the requested resource (post workspaceauthenticationconfigurations.tenancy.kcp.io)" does not contain "claim and expression cannot both be specified"
    	Test:       	TestAcceptableWorkspaceAuthenticationConfigurations/claim-and-expression

The reason for this is that the fixture only waits for the workspace and underlying logical cluster to be ready.

Instead the fixture now waits until all APIBindings (which are usually just the kcp APIs) are bound.

What Type of PR Is This?

/kind flake
/kind bug

Related Issue(s)

Fixes #

Release Notes

NONE

[ntnn]

Just had another failure just like it:

     controller_test.go:89: 
        	Error Trace:	/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/workspacedeletion/controller_test.go:89
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/workspacedeletion/controller_test.go:318
        	Error:      	Received unexpected error:
        	            	the server could not find the requested resource (post workspaces.tenancy.kcp.io)
        	Test:       	TestWorkspaceDeletion/create_and_clean_workspace 

[ntnn]

I think this is due to #3847 as the installation of resources is done by confighelpers.Bootstrap, which now installs the bootstrapped resources in groups rather than trying to install everything at once and retrying until they install.

I remember seeing this error beforehand as well, the change just made it more pronounced, probably because there's at least one resource group being installed before the APIBindings.

[mjudeikis]

/lgtm
/approve

[kcp-ci-bot]

LGTM label has been added.

Details

Git tree hash: e43e1d8bc65fae236528e9811668d4af033f0b0c

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• staging/src/github.com/kcp-dev/sdk/OWNERS [mjudeikis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ntnn]

/retest

Haven't seen that one flake before:

     inactive_test.go:55: Mark the logicalcluster as inactive
    inactive_test.go:58: 
        	Error Trace:	/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/workspace/inactive_test.go:58
        	Error:      	Received unexpected error:
        	            	Operation cannot be fulfilled on logicalclusters.core.kcp.io "cluster": the object has been modified; please apply your changes to the latest version and try again
        	Test:       	TestInactiveLogicalCluster