Skip to content

Wrap WorkspaceType creation in EventuallyWithT#3929

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
ntnn:kcp-TestTerminatingWorkspacesVirtualWorkspaceAccess
Mar 20, 2026
Merged

Wrap WorkspaceType creation in EventuallyWithT#3929
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
ntnn:kcp-TestTerminatingWorkspacesVirtualWorkspaceAccess

Conversation

@ntnn
Copy link
Member

@ntnn ntnn commented Mar 20, 2026

Summary

Seen a few failures where WorkspaceType creation failed with:

    virtualworkspace_test.go:154: 
        	Error Trace:	/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/virtual/terminatingworkspaces/virtualworkspace_test.go:154
        	Error:      	Received unexpected error:
        	            	the server could not find the requested resource (post workspacetypes.tenancy.kcp.io)
        	Test:       	TestTerminatingWorkspacesVirtualWorkspaceAccess

That is a bit odd but in CI can see that the APIs being established takes a bit longer than the time the test goes from workspace being created and this call happening.

What Type of PR Is This?

/kind flake

Related Issue(s)

Fixes #

Release Notes

NONE

Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2026
@ntnn
Copy link
Member Author

ntnn commented Mar 20, 2026

/mergetype squash

@ntnn ntnn added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 20, 2026
@ntnn ntnn added this to tbd Mar 20, 2026
@github-project-automation github-project-automation bot moved this to Backlog in tbd Mar 20, 2026
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: d83820c7fd7b69c85ca5ed55eac81c3f98eba869

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@kcp-ci-bot kcp-ci-bot merged commit ae7e418 into kcp-dev:main Mar 20, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in tbd Mar 20, 2026
@ntnn ntnn deleted the kcp-TestTerminatingWorkspacesVirtualWorkspaceAccess branch March 20, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants