Skip to content

feature: Validate loopvar comment/removed the loopvar comment#3921

Open
Nishant-k-sagar wants to merge 1 commit intokcp-dev:mainfrom
Nishant-k-sagar:loopvar-comment-validation
Open

feature: Validate loopvar comment/removed the loopvar comment#3921
Nishant-k-sagar wants to merge 1 commit intokcp-dev:mainfrom
Nishant-k-sagar:loopvar-comment-validation

Conversation

@Nishant-k-sagar
Copy link

@Nishant-k-sagar Nishant-k-sagar commented Mar 18, 2026

Summary

I validated the tests on local. All tests passed. As per mentioned in issue #3914 loopvar comment is removed.

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #3914

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 18, 2026
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mjudeikis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2026
@kcp-ci-bot
Copy link
Contributor

Hi @Nishant-k-sagar. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Nishant-k-sagar <147799872+Nishant-k-sagar@users.noreply.github.com>
@Nishant-k-sagar Nishant-k-sagar force-pushed the loopvar-comment-validation branch from de48d98 to 9234c69 Compare March 18, 2026 12:30
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Mar 18, 2026
@Nishant-k-sagar
Copy link
Author

Hi @ntnn,
I have cleaned up the loopvar comments. Then, I ran the local tests, all the local tests passed.
Kindly, let me know If anything else is to be done regarding this issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Validate loopvar comment

2 participants