Add --logging-format to cache-server and use ISO8601 timestamps in JSON logs#3904
Open
xrstf wants to merge 3 commits intokcp-dev:mainfrom
Open
Add --logging-format to cache-server and use ISO8601 timestamps in JSON logs#3904xrstf wants to merge 3 commits intokcp-dev:mainfrom
xrstf wants to merge 3 commits intokcp-dev:mainfrom
Conversation
… instead of UNIX timestamps On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/kind cleanup |
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--logging-formatflag support to cache-serverChanges
pkg/logging/json: Custom JSON logger factory that wraps upstream implementation but uses ISO8601 time encodinggithub.com/kcp-dev/kcp/pkg/logging/json/registerinstead ofk8s.io/component-base/logs/json/registerTest plan
--logging-format=jsonflag"ts":"2026-03-13T10:30:45.123Z") instead of UNIX timestamps