make it easier to import the crdpuller from other projects#3887
Draft
xrstf wants to merge 1 commit intokcp-dev:mainfrom
Draft
make it easier to import the crdpuller from other projects#3887xrstf wants to merge 1 commit intokcp-dev:mainfrom
xrstf wants to merge 1 commit intokcp-dev:mainfrom
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
part of kcp-dev/api-syncagent#146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The api-syncagent imports the crdpuller. Today I tried updating its dependencies to the latest multicluster-runtime, but this would bring the agent to Kubernetes 1.35. This then clashes with the import to kcp when running
go mod tidy:For testing, I copied the entire crdpuller package into the syncagent and just removed the line about filtering resources part of apiextensions-apiserver. This solved the dependency hell. Therefore I think it's worth it to introduce a small indirection in kcp: instead of hardcoding a specific scheme in the crdpuller to ignore, it can now be configured by the caller, and in a separate package we provide the default scheme to ignore.
I provided a public MergeSchemes func to aid people in constructing their own scheme to ignore.
What Type of PR Is This?
/kind cleanup
Release Notes