Conversation
2e8c32c to
c69d026
Compare
cbe9740 to
31f3761
Compare
31f3761 to
a050b19
Compare
|
/assign |
|
I'll give it a try tomorrow, thanks for the work! |
There was a problem hiding this comment.
I think we should explicitly list the expected node selector values, i.e. auxiliary, kcp-frontproxy, kcp-etcd, kcp-server
There was a problem hiding this comment.
I have now directly mentioned the kind example to look up to see all the different nodepools
|
For reference I deployed this in infra, where it looks like its working and in kind where it breaks. The kind setup:
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
- role: worker
labels:
role: "kcp-frontproxy"
- role: worker
labels:
role: "kcp-etcd"
- role: worker
labels:
role: "kcp-server"
- role: worker
labels:
role: "auxiliary"
apiVersion: v1
kind: Service
metadata:
name: frontproxy
namespace: kcp
spec:
type: ExternalName
externalName: frontproxy-front-proxy.kcp.svc.cluster.local
---
apiVersion: v1
kind: Service
metadata:
name: root
namespace: kcp
spec:
type: ExternalName
externalName: root-kcp.kcp.svc.cluster.local
---
apiVersion: v1
kind: Service
metadata:
name: shard2
namespace: kcp
spec:
type: ExternalName
externalName: shard2-shard-kcp.kcp.svc.cluster.local
---
apiVersion: v1
kind: Service
metadata:
name: shard3
namespace: kcp
spec:
type: ExternalName
externalName: shard3-shard-kcp.kcp.svc.cluster.local
export NODEPOOL_SELECTOR="role"
export GATEWAY_BASE_URL="kcp.svc.cluster.local"
export GATEWAY_ANNOTATIONS="{'hello':'world'}"
Then e.g. front proxy fails with these messages: I think adding the cert template should make this work in more setups |
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
8dff1a5 to
7f22c11
Compare
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
6605deb to
a9ee7e5
Compare
|
I think all comments have been addressed ptal |
|
LGTM label has been added. DetailsGit tree hash: cff99879aab7e7c86f735beeaf3135acc4e6a2e3 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR adds a setup script to setup loadtesting on infra which has the required nodepools in place.
What Type of PR Is This?
/kind feature
Release Notes