Skip to content

Add pkg/errgroup#3861

Merged
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
ntnn:concurrency-errgroup
Feb 26, 2026
Merged

Add pkg/errgroup#3861
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
ntnn:concurrency-errgroup

Conversation

@ntnn
Copy link
Member

@ntnn ntnn commented Feb 25, 2026

Summary

Add pkg/errgroup. See #3847 (comment)

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 25, 2026
ntnn added 2 commits February 25, 2026 22:48
@ntnn
Add errgroup
ddf7ca6 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Add errgroup tests
a03109d 
By geClaude

Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn ntnn force-pushed the concurrency-errgroup branch from 70e0f17 to a03109d Compare February 25, 2026 21:48
@ntnn
Copy link
Member Author

ntnn commented Feb 25, 2026 •
edited
Loading

/test pull-kcp-test-e2e-sharded

#3860

1 similar comment
@ntnn
Copy link
Member Author

ntnn commented Feb 25, 2026

/test pull-kcp-test-e2e-sharded

#3860

@olamilekan000
Copy link
Contributor

olamilekan000 commented Feb 25, 2026

/restart

1 similar comment
@olamilekan000
Copy link
Contributor

olamilekan000 commented Feb 25, 2026

/restart

@ntnn
Copy link
Member Author

ntnn commented Feb 26, 2026

/retest

mjudeikis
mjudeikis reviewed Feb 26, 2026
View reviewed changes
pkg/errgroup/errgroup.go
@@ -0,0 +1,119 @@
/*
Copyright 2025 The KCP Authors.
Copy link
Contributor

@mjudeikis mjudeikis Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026

mjudeikis
mjudeikis approved these changes Feb 26, 2026
View reviewed changes
Copy link
Contributor

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Feb 26, 2026

LGTM label has been added.

DetailsGit tree hash: de4957a7bb90c4d980782028f740330a71e9e49e

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@ntnn
Copy link
Member Author

ntnn commented Feb 26, 2026

/test pull-kcp-test-e2e-sharded

3 similar comments
@ntnn
Copy link
Member Author

ntnn commented Feb 26, 2026

/test pull-kcp-test-e2e-sharded

@ntnn
Copy link
Member Author

ntnn commented Feb 26, 2026

/test pull-kcp-test-e2e-sharded

@ntnn
Copy link
Member Author

ntnn commented Feb 26, 2026

/test pull-kcp-test-e2e-sharded

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Feb 26, 2026

@ntnn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e-sharded a03109d link true /test pull-kcp-test-e2e-sharded

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ntnn
Copy link
Member Author

ntnn commented Feb 26, 2026

/retest

@kcp-ci-bot kcp-ci-bot merged commit 830ca86 into kcp-dev:main Feb 26, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ntnn @olamilekan000 @kcp-ci-bot @mjudeikis