add ability to reference OIDC client secret from secret object#134
add ability to reference OIDC client secret from secret object#134olamilekan000 wants to merge 1 commit intokcp-dev:mainfrom
Conversation
Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mjudeikis
left a comment
There was a problem hiding this comment.
This is just api? no implementation yet?
| Name string `json:"name"` | ||
| // Namespace is the namespace of the secret. If not specified, the secret is assumed to be in the same namespace as the resource. | ||
| // +optional | ||
| Namespace string `json:"namespace,omitempty"` |
There was a problem hiding this comment.
Is there point having namespace here? Can we refer and use secrets cross-namespaces?
There was a problem hiding this comment.
Unless there's a strong reason to read cross-namespace resources, I would also vote against opening this can of worms.
There was a problem hiding this comment.
Although, now that I think about it - it'd just but a blocker in if someone does need to read cross-namespace resources.
There was a problem hiding this comment.
Then again, I think it'd be best to reuse the LocalDataKeyRef:
kcp-operator/sdk/apis/operator/v1alpha1/common.go
Lines 73 to 81 in 7b7489f
There was a problem hiding this comment.
okay, will look into this
Summary
What Type of PR Is This?
/kind feature
/kind api-change
Related Issue(s)
Fixes 130
Release Notes