Skip to content

NCBI FTP Integration #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattldawson wants to merge 80 commits into
base: develop
Choose a base branch
from

capture missing return values

c01dbdc
Select commit
Loading
Failed to load commit list.
Open

NCBI FTP Integration #133

capture missing return values
c01dbdc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 30, 2026 in 0s

66.14% (+5.67%) compared to 15ba0ef

View this Pull Request on Codecov

66.14% (+5.67%) compared to 15ba0ef

Details

Codecov Report

❌ Patch coverage is 85.71429% with 137 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.14%. Comparing base (15ba0ef) to head (c01dbdc).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdm_data_loaders/ncbi_ftp/assembly.py 42.22% 52 Missing ⚠️
src/cdm_data_loaders/ncbi_ftp/manifest.py 88.05% 32 Missing ⚠️
src/cdm_data_loaders/ncbi_ftp/promote.py 89.35% 23 Missing ⚠️
...rc/cdm_data_loaders/pipelines/ncbi_ftp_download.py 91.97% 13 Missing ⚠️
src/cdm_data_loaders/utils/ftp_client.py 90.12% 8 Missing ⚠️
src/cdm_data_loaders/utils/s3.py 86.04% 6 Missing ⚠️
src/cdm_data_loaders/ncbi_ftp/metadata.py 96.20% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #133      +/-   ##
===========================================
+ Coverage    60.47%   66.14%   +5.67%     
===========================================
  Files           64       71       +7     
  Lines         3370     4307     +937     
===========================================
+ Hits          2038     2849     +811     
- Misses        1332     1458     +126
Files with missing lines Coverage Δ
src/cdm_data_loaders/utils/checksums.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/ncbi_ftp/metadata.py 96.20% <96.20%> (ø)
src/cdm_data_loaders/utils/s3.py 92.59% <86.04%> (+3.36%) ⬆️
src/cdm_data_loaders/utils/ftp_client.py 90.12% <90.12%> (ø)
...rc/cdm_data_loaders/pipelines/ncbi_ftp_download.py 91.97% <91.97%> (ø)
src/cdm_data_loaders/ncbi_ftp/promote.py 89.35% <89.35%> (ø)
src/cdm_data_loaders/ncbi_ftp/manifest.py 88.05% <88.05%> (ø)
src/cdm_data_loaders/ncbi_ftp/assembly.py 42.22% <42.22%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf29cb...c01dbdc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov