Skip to content

Conversation

@jkj
Copy link

@jkj jkj commented Apr 23, 2018

Simple change to use ${CC} to created shared objects rather than using ld directly, so that the compiler driver has the opportunity to do things the way it wants them done.

Copy link
Owner

@katef katef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will break for macos, because the other flags for LDFLAGS are written for ld, not cc. e.g.:

LDSFLAGS += -macosx_version_min ${MACOSX_VERSION_MIN}

for some cases gcc has an equivalent flag to pass those along (i.e. -mmacosx_version_min, with the extra m).

For -dylib -flat_namespace -undefined dynamic_lookup I haven't checked. Those could be passed along by -Wl,... but if we're calling ${CC} here I'd rather use gcc and clang's equivalent flags where they're provided.

#

LD ?= ld
SOLD ?= ${CC}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call that LDS, because it matches LDSFLAGS below

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the manpages too please!

@katef katef changed the base branch from master to main June 14, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants