Allow air to run without go/bin#18
Conversation
dankinder
left a comment
There was a problem hiding this comment.
Thanks Jon. I'd actually prefer we not try to enforce that go/bin is in the user's path with every command we want to run, because it adds those ugly exports all over the Taskfile and is unnecessary for most users.
How about after the go install ...air@v1.52.2 command we check if air is now executable, and if $(command -v air) is still false, we issue a warning like "WARNING: Attempted to go install the air command, but it still couldn't be found; to fix try adding ~/bin/go to your PATH like so: go env GOPATH >> .bashrc"
We'd still move on with the rest of the install process.
|
Sounds good, added a warning. |
Taskfile.yml
Outdated
| set: | ||
| - pipefail | ||
|
|
There was a problem hiding this comment.
We can take this out
package-lock.json
Outdated
| "version": "6.3.5", | ||
| "resolved": "https://registry.npmjs.org/vite/-/vite-6.3.5.tgz", | ||
| "integrity": "sha512-cZn6NDFE7wdTpINgs++ZJ4N49W2vRp8LCKrn3Ob1kYNtOo21vfDoaV5GzBfLU4MovSAB8uNRm4jgzVQZ+mBzPQ==", | ||
| "version": "6.4.1", | ||
| "resolved": "https://registry.npmjs.org/vite/-/vite-6.4.1.tgz", | ||
| "integrity": "sha512-+Oxm7q9hDoLMyJOYfUYBuHQo+dkAloi33apOPP56pzj+vsdJDzr+j1NISE5pyaAuKL4A3UD34qd0lx5+kfKp2g==", | ||
| "license": "MIT", |
There was a problem hiding this comment.
Seems like an unintentional change?
When running air, we check to ensure that go/bin is in the path.
Testing steps:
/go/binfromPATHtask devstill works