Skip to content

Allow air to run without go/bin#18

Merged
dankinder merged 3 commits intokatabole:mainfrom
jonyen:issue-8_allow-air-to-run-without-go-bin
Nov 10, 2025
Merged

Allow air to run without go/bin#18
dankinder merged 3 commits intokatabole:mainfrom
jonyen:issue-8_allow-air-to-run-without-go-bin

Conversation

@jonyen
Copy link
Contributor

@jonyen jonyen commented Nov 9, 2025

When running air, we check to ensure that go/bin is in the path.

Testing steps:

  1. Remove /go/bin from PATH
  2. Verify that task dev still works

Copy link
Contributor

@dankinder dankinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jon. I'd actually prefer we not try to enforce that go/bin is in the user's path with every command we want to run, because it adds those ugly exports all over the Taskfile and is unnecessary for most users.

How about after the go install ...air@v1.52.2 command we check if air is now executable, and if $(command -v air) is still false, we issue a warning like "WARNING: Attempted to go install the air command, but it still couldn't be found; to fix try adding ~/bin/go to your PATH like so: go env GOPATH >> .bashrc"

We'd still move on with the rest of the install process.

@jonyen
Copy link
Contributor Author

jonyen commented Nov 10, 2025

Sounds good, added a warning. .zshrc is the default for modern Macs now

Taskfile.yml Outdated
Comment on lines +3 to +5
set:
- pipefail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can take this out

Comment on lines +1355 to +1358
"version": "6.3.5",
"resolved": "https://registry.npmjs.org/vite/-/vite-6.3.5.tgz",
"integrity": "sha512-cZn6NDFE7wdTpINgs++ZJ4N49W2vRp8LCKrn3Ob1kYNtOo21vfDoaV5GzBfLU4MovSAB8uNRm4jgzVQZ+mBzPQ==",
"version": "6.4.1",
"resolved": "https://registry.npmjs.org/vite/-/vite-6.4.1.tgz",
"integrity": "sha512-+Oxm7q9hDoLMyJOYfUYBuHQo+dkAloi33apOPP56pzj+vsdJDzr+j1NISE5pyaAuKL4A3UD34qd0lx5+kfKp2g==",
"license": "MIT",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an unintentional change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not needed.

@dankinder dankinder merged commit 20d1ee5 into katabole:main Nov 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants