Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

logger: Fix syslog identifier.#29

Merged
sameo merged 1 commit intokata-containers:masterfrom
jodh-intel:fix-syslog-identifier
Jan 18, 2018
Merged

logger: Fix syslog identifier.#29
sameo merged 1 commit intokata-containers:masterfrom
jodh-intel:fix-syslog-identifier

Conversation

@jodh-intel
Copy link
Copy Markdown

Ensure log entries specify the name of the proxy, not its path.

Fixes #28.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

Ensure log entries specify the name of the proxy, not its path.

Fixes kata-containers#28.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel
Copy link
Copy Markdown
Author

Related: #26.

@sameo
Copy link
Copy Markdown

sameo commented Jan 15, 2018

LGTM

Approved with PullApprove

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2018

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   34.34%   34.34%           
=======================================
  Files           1        1           
  Lines          99       99           
=======================================
  Hits           34       34           
  Misses         58       58           
  Partials        7        7
Impacted Files Coverage Δ
proxy.go 34.34% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b739853...ee9673d. Read the comment docs.

Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sameo
Copy link
Copy Markdown

sameo commented Jan 18, 2018

@bergwolf @laijs Could you please have a look?

@laijs
Copy link
Copy Markdown
Contributor

laijs commented Jan 18, 2018

LGTM

Approved with PullApprove

@sameo sameo merged commit a7a7be8 into kata-containers:master Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants