Changed the backward method implementation from recursive to stack#90
Open
Mikelenjilo wants to merge 1 commit intokarpathy:masterfrom
Open
Changed the backward method implementation from recursive to stack#90Mikelenjilo wants to merge 1 commit intokarpathy:masterfrom
Mikelenjilo wants to merge 1 commit intokarpathy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run into a proble of
RecursionErrorwhen the depth of the graph is longer than 1000. That may happen when there is a very long mathematical expression based on atomic operations (+, -, etc.). So the new implementation is based on the DPS algorithm using a stack. This removes the recursion limit (default to 1000) and can create a topological graph for an infinite depth.