Simplify backward pass by returning local gradients per op#115
Open
Lyt060814 wants to merge 1 commit intokarpathy:masterfrom
Open
Simplify backward pass by returning local gradients per op#115Lyt060814 wants to merge 1 commit intokarpathy:masterfrom
Lyt060814 wants to merge 1 commit intokarpathy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As suggested by @karpathy in this tweet (a follow-up to the microgpt announcement):
This PR implements that simplification:
_local_gradstuple instead of defining a_backwardclosurebackward()uniformly applies the chain rule by multiplying local gradients with the upstream gradient_childrenkept as tuple instead ofset()to preserve ordering correspondence with_local_gradsTest plan
pytest test/test_engine.py— forward and backward results match PyTorch (bothtest_sanity_checkandtest_more_ops)demo.ipynb— MLP training on make_moons converges to 100% accuracy, loss curve unchangedtrace_graph.ipynb— computation graph visualization works correctly