feat(java-jaxrs-common): improve code generation for comparison methods in POJOs#77
Open
Dakskihedron wants to merge 5 commits intokarlvr:mainfrom
Open
feat(java-jaxrs-common): improve code generation for comparison methods in POJOs#77Dakskihedron wants to merge 5 commits intokarlvr:mainfrom
Dakskihedron wants to merge 5 commits intokarlvr:mainfrom
Conversation
Correctly use java.util.Arrays.equals to compare byte arrays for file properties.
Let Lombok generate the equals and hashCode methods when useLombok is true. Lombok will use the correct utility classes to handle comparisons for objects like arrays.
…or POJO properties
…lean properties Drop the extra "is" (if present) from the property identifier during setter generation when Lombok is used and the property is a primitive boolean. This ensures the Lombok setter is correctly called.
Dakskihedron
changed the title
Dakskihedron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes byte array comparison for file properties by using
java.util.Arrays.equalsinstead ofjava.util.Objects.equals. Also use Lombok to generate theequalsandhashCodemethods in POJOs whenuseLombok: trueso the correct utility classes are automatically used when comparing objects.