Open
Conversation
Merging dev 1.1.0 branch to master
merging 1.1.0 which is passing all builds on travis
fixed travis badge
Fixed gsl dependency issue
Bring fork up to date
fixed gsl dependency issue
Here are some of my data structures for usage with GIST data and a short working example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kamran,
here are the recent changes I made to the longrange Eww routines. Now SiteWaterAnalysis can handle any set of shell radii and also any kind of shell candidate atoms, although the latter is not heavily tested. In terms of speed, the improvements are small for low number of shells, but should grow the more shells you add.
Tobias