Expose cause for EmailVerifier::OutOfMailServersException#33
Open
g0ody wants to merge 1 commit intokamilc:masterfrom
Open
Expose cause for EmailVerifier::OutOfMailServersException#33g0ody wants to merge 1 commit intokamilc:masterfrom
g0ody wants to merge 1 commit intokamilc:masterfrom
Conversation
|
Hey @g0ody, we're having some issues, since we are receiving this exception for emails that are actually valid. Can you explain how your change affects the behaviour of the gem? |
Author
|
Before it raise the EmailVerifier::OutOfMailServersException when servers are nil. This was caused by the retry. But this way you use the cause EmailVerifier::OutOfMailServersException, that is provided by ruby automatically if you raise an exception in a rescue function. So I restructure the call so that the exception is raised in the rescue function, to be able to access the original execption when EmailVerifier::OutOfMailServersException is raised. Other than that the behaviour stays the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed the internal reason why EmailVerifier::OutOfMailServersException was caused. If retry is used rubies nested exceptions do not work.