Open
Conversation
Owner
There was a problem hiding this comment.
We have to check if it's present some other way, since present? method is being added by Rails. We want to be independent of Rails while supporting it when it's present.
Owner
|
Other than the thing I commented on above, I noticed that it stopped working for me. irb(main):002:0> EmailVerifier.check "ciemniewski.kamil@gmail.com"
EmailVerifier::NoMailServerException: No mail server for ciemniewski.kamil@gmail.comWhile the version from master just works: irb(main):002:0> EmailVerifier.check "ciemniewski.kamil@gmail.com"
=> trueIt can't be merged in at this moment. Could you take a look and provide any fixes? I like the change — it would be great to have it in master. Thanks |
Author
|
Thanks for reviewing it. I just tried the check you posted, and it seems to work fine for me? Could you try once more to make sure it wasn't some strange DNS issue? Otherwise I'll try to dig a bit deeper... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a couple of cleanups, reduces timeouts (30/60 secs is usually too long), and will also fallback to the A record in case no MX record is given (as per RFC).