This repository was archived by the owner on Dec 21, 2019. It is now read-only.
An infinite loop was corrected. #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dynamic loading of scripts. Supported methods: - build_from_components - write_from_components
What processed once excluded it. Signed-off-by: holy <holy.shared.design@gmail.com>
Owner
|
cool stuff, I'll test and pull asap. |
Contributor
|
Nice! |
…entry in the manifest.
…and remove_blocks
…since the first time is corrected.
Signed-off-by: Noritaka Horio <holy.shared.design@gmail.com>
… the build Signed-off-by: Noritaka Horio <holy.shared.design@gmail.com>
…od of outputting the message is appropriately changed. php://stderr to php://stdout
Signed-off-by: Noritaka Horio <holy.shared.design@gmail.com>
…thout breaking the interface) needs to be refactored. Going to start testing for correctness next.
… one array. Not a multi-dimensional array.
…but could be changed in the future. I also organized, in alphabetical order packager.php. /me gets the shield ready.
…oing to add a source dynamically into a package.
…reak everything. ;)
…ckager. As on now, Package is just a nice container of sources. Sources are a container of requires and provides, and each requires and provides is added to Packager so that it builds the graph. Next, I need to create and populate the graph, search and find components, iterate the graph for dependencies, and build a chain.
The graph structure is just two arrays. First for sources, and the other for source index keys. The keys are generated by generators that can be programmatically be added. See #configure method. Tip: override configure and add your own generators above or below the parent::configure call. Still missing the add_dependency and build methods.
…to test Packager::build.
that should be doing the processing of the output. Perhaps build should return a 'Build' class that has a lot of utility functions like strip_blocks.
…missing closing ')')
order (Core, for example, would be first). This is now the case, since I needed to recursively look for the most required component. I've also added the ability to pass Source instances to required method in Source.
…of refactoring for more DRY. This also includes a shift from throwing an Exception if the source is not found in the build process. This would allow for -packages or +use-only in cli (that's next).
Conflicts: README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TestA and TestB need each other, an infinite loop is generated.
The verification prepared and confirmed following test files TestA and TestB.
Source header of TestA.js
Source header of TestB.js
To solve an infinite loop, it was corrected that the file processed once was not processed.