This repository was archived by the owner on Dec 21, 2019. It is now read-only.
Update browser.js #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its a extrem silly bug. At some Android Versions i get an error: "Cannot call method 'replace' of null". I get the error on my application with several thousand users a day, only at a handful of android devices. like: browser - Mozilla/5.0 (Linux; U; Android 4.3; de-de; GT-I9300 Build/JSS15J) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30 The main error are on line 841 at moofx.js. properties = (rules(transitionName + "Property").replace(/\s+/g, "") that fix works for me, unfortunately I can not assess whether this fix has any impacts. for me all runs fine :-) if you want you can include this fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a extrem silly bug. At some Android Versions i get an error: "Cannot call method 'replace' of null".
I get the error on my application with several thousand users a day, only at a handful of android devices.
like: browser - Mozilla/5.0 (Linux; U; Android 4.3; de-de; GT-I9300 Build/JSS15J) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30
The main error are on line 841 at moofx.js.
properties = (rules(transitionName + "Property").replace(/\s+/g, "")
that fix works for me, unfortunately I can not assess whether this fix has any impacts. for me all runs fine :-) if you want you can include this fix