Refine live subscriptions & materialization#250
Merged
Conversation
Add validation and helper functions for websocket subscription options (prevent last_rows > batch_size) and return early on invalid options. Refactor initial data fetching: introduce TableCapabilities, reduce repeated schema lookups, move heavy row materialization to a blocking task when large, and centralize materialization logic with many unit/integration tests covering resume/last-row behaviors. Simplify connection metadata by removing a custom string-intern pool in favor of Arc-owned strings and update tests accordingly. Optimize notification dispatch for single and small fan-outs (add dispatch_one) to avoid extra cloning/spawning. Update benchmark tooling: add --output-dir, reorganize chat realtime benchmark into chat_runtime, and adjust benchmark registration/selection and scripts. Minor formatting and dependency lock updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation and helper functions for websocket subscription options (prevent last_rows > batch_size) and return early on invalid options. Refactor initial data fetching: introduce TableCapabilities, reduce repeated schema lookups, move heavy row materialization to a blocking task when large, and centralize materialization logic with many unit/integration tests covering resume/last-row behaviors. Simplify connection metadata by removing a custom string-intern pool in favor of Arc-owned strings and update tests accordingly. Optimize notification dispatch for single and small fan-outs (add dispatch_one) to avoid extra cloning/spawning. Update benchmark tooling: add --output-dir, reorganize chat realtime benchmark into chat_runtime, and adjust benchmark registration/selection and scripts. Minor formatting and dependency lock updates.