Open
Conversation
dosubot
bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #217 (review), move the
/graph/v3/queryendpoint from the v2QueryControllerto the v3 layer.Integrate the ActionbaseQuery execution path into V3QueryService, following the
existing v3 pattern (V3QueryService → Graph).
Changes
query(ActionbaseQuery)method toV3QueryService— delegates tograph.query()ActionbaseQueryControllerin the v3 package (POST /graph/v3/query)NamedQueryResultV3into a dedicated file in the v3 packagequeryV3()andNamedQueryResultV3from v2QueryControllerChecklist
./gradlew build)