Update deps, use esm#1
Open
tcastelly wants to merge 5 commits into
Open
Conversation
|
Tested this - including prod build. Seems to work nicely. |
andys8
reviewed
Sep 29, 2022
| "spago": "spago", | ||
| "start": "vite", | ||
| "start:spago": "spago build --watch", | ||
| "transform-require": "node scripts/transform-require.js", |
There was a problem hiding this comment.
❓ The execution of scripts/transform-require.js is being removed in this PR.
- Why is this step not necessary anymore? Still the bundled output is used because of the HTML, right? But why was this script there before?
- If the script can be removed, the folder
scriptsshould be deleted in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has been updated:
Add ESM compatibility.