Skip to content

test(controller): add goleak test cases to detect goroutine leaks #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dongjiang1989 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

test(controller): add goleak test cases to detect goroutine leaks #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions go/core/internal/controller/goleak_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package controller

import (
"testing"

"go.uber.org/goleak"
)

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
Comment thread
dongjiang1989 marked this conversation as resolved.
}
5 changes: 5 additions & 0 deletions go/core/internal/controller/reconciler/mcp_server_reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.uber.org/goleak"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
schemev1 "k8s.io/client-go/kubernetes/scheme"
Expand All @@ -18,6 +19,10 @@ import (
"github.com/kagent-dev/kmcp/api/v1alpha1"
)

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
}
Comment thread
dongjiang1989 marked this conversation as resolved.

// TestReconcileKagentMCPServer_ErrorPropagation tests that errors from conversion
// are properly propagated and not silently swallowed. This is a regression test
// for the original issue where errors were only logged.
Expand Down
1 change: 1 addition & 0 deletions go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ require (
go.opentelemetry.io/otel/sdk v1.43.0
go.opentelemetry.io/otel/trace v1.43.0
go.uber.org/automaxprocs v1.6.0
go.uber.org/goleak v1.3.0
go.uber.org/zap v1.27.1
golang.org/x/text v0.36.0
google.golang.org/adk v1.1.0
Expand Down
Loading