Skip to content

feat: adding configurable ssh-hosts for git-based skills#1525

Merged
EItanya merged 6 commits intokagent-dev:mainfrom
jmunozro:jmunozro/configurable-ssh-hosts
Mar 19, 2026
Merged

feat: adding configurable ssh-hosts for git-based skills#1525
EItanya merged 6 commits intokagent-dev:mainfrom
jmunozro:jmunozro/configurable-ssh-hosts

Conversation

@jmunozro
Copy link
Contributor

Fixes #1524

Copilot AI review requested due to automatic review settings March 19, 2026 10:53
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
@jmunozro jmunozro force-pushed the jmunozro/configurable-ssh-hosts branch from 8e80dc9 to e2c11ac Compare March 19, 2026 10:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for scanning SSH host keys for custom Git servers when initializing git-based skills, addressing issue #1524 so SSH clones work beyond the previously hardcoded public hosts.

Changes:

  • Extend the skills-init script template to run ssh-keyscan for additional SSH hosts (including optional ports).
  • Update the agent translator to extract unique SSH hosts/ports from ssh:// GitRefs and pass them into the template.
  • Expand translator tests to cover custom SSH host scanning and make auth secret assertions dynamic.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
go/core/internal/controller/translator/agent/skills-init.sh.tmpl Renders additional ssh-keyscan lines for extracted SSH hosts/ports.
go/core/internal/controller/translator/agent/adk_api_translator.go Parses SSH GitRef URLs to produce a unique list of hosts/ports for the init script.
go/core/internal/controller/translator/agent/git_skills_test.go Adds a test case for SSH URL host scanning and adjusts secret name assertion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
@jmunozro
Copy link
Contributor Author

@copilot open a new pull request to apply changes based on the comments in this thread

Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
@EItanya EItanya merged commit 3035192 into kagent-dev:main Mar 19, 2026
22 checks passed
@jmunozro jmunozro deleted the jmunozro/configurable-ssh-hosts branch March 19, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] skills-init: ssh-keyscan only runs for hardcoded hosts, breaking SSH clones from custom Git servers

3 participants