feat: adding configurable ssh-hosts for git-based skills#1525
Merged
EItanya merged 6 commits intokagent-dev:mainfrom Mar 19, 2026
Merged
feat: adding configurable ssh-hosts for git-based skills#1525EItanya merged 6 commits intokagent-dev:mainfrom
EItanya merged 6 commits intokagent-dev:mainfrom
Conversation
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
8e80dc9 to
e2c11ac
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for scanning SSH host keys for custom Git servers when initializing git-based skills, addressing issue #1524 so SSH clones work beyond the previously hardcoded public hosts.
Changes:
- Extend the
skills-initscript template to runssh-keyscanfor additional SSH hosts (including optional ports). - Update the agent translator to extract unique SSH hosts/ports from
ssh://GitRefs and pass them into the template. - Expand translator tests to cover custom SSH host scanning and make auth secret assertions dynamic.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| go/core/internal/controller/translator/agent/skills-init.sh.tmpl | Renders additional ssh-keyscan lines for extracted SSH hosts/ports. |
| go/core/internal/controller/translator/agent/adk_api_translator.go | Parses SSH GitRef URLs to produce a unique list of hosts/ports for the init script. |
| go/core/internal/controller/translator/agent/git_skills_test.go | Adds a test case for SSH URL host scanning and adjusts secret name assertion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
go/core/internal/controller/translator/agent/skills-init.sh.tmpl
Outdated
Show resolved
Hide resolved
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
Signed-off-by: Jesus Munoz <jesus.munoz@solo.io>
EItanya
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1524